Re: [PATCH v3 1/9] mfd: max77705: max77705_charger: move active discharge setting to mfd parent

[Lee Jones]

On Mon, 15 Sep 2025, Sebastian Reichel wrote:

> Hi,
> 
> On Thu, Sep 11, 2025 at 08:57:09PM +0300, Dzmitry Sankouski wrote:
> > Active discharge setting is a part of MFD top level i2c device, hence
> > cannot be controlled by charger. Writing to MAX77705_PMIC_REG_MAINCTRL1
> > register from charger driver is a mistake.
> >
> > Move active discharge setting to MFD parent driver.
> 
> This is quite confusing to read without knowing the driver. I think
> it's betterly described like this:
> 
> Active discharge setting is a part of MFD top level register range,
> hence cannot be controlled by the charger regmap, which only offers
> access to the charger registers.
> 
> Move active discharge setting to MFD parent driver to fix the issue.
> 
> > 
> > Fixes: a6a494c8e3ce ("power: supply: max77705: Add charger driver for Maxim 77705")
> > 
> 
> No newline after Fixes:
> 
> > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
> > ---
> >  drivers/mfd/max77705.c                  | 3 +++
> >  drivers/power/supply/max77705_charger.c | 3 ---
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> I think it's sensible to use 'mfd: max77705:' prefix for this patch,
> otherwise Lee easily misses that this patchset has anything to do
> with his subsystem :)

=:-)

-- 
Lee Jones [李琼斯]