Re: [PATCH v5 0/2] clk: amlogic: add video-related clocks for S4 SoC

[Chuan Liu]

Hi Jerome:


On 9/16/2025 3:47 PM, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
>
> On Tue 16 Sep 2025 at 10:06, Chuan Liu via B4 Relay <devnull+chuan.liu.amlogic.com@xxxxxxxxxx> wrote:
>
> > This patch introduces new clock support for video processing components
> > including the encoder, demodulator and CVBS interface modules.
> >
> > The related clocks have passed clk-measure verification.
> >
> > Signed-off-by: Chuan Liu <chuan.liu@xxxxxxxxxxx>
> > ---
> > Changes in v5:
> > - Add Acked-by tags from Conor.
> > - Remove unnecessary flags as suggested by Jerome.
> The request was "in an another change" ? Why was this ignored ?


Sorry to bother you. I'll drop the flags for 's4_cts_encl_sel' in this
series and submit a separate patch later to remove CLK_SET_RATE_PARENT
from enci/encp/cdac/hdmitx clk_muxes. Is that ok?


> > - Link to v4: https://lore.kernel.org/r/20250909-add_video_clk-v4-0-5e0c01d47aa8@xxxxxxxxxxx
> >
> > Changes in v4:
> > - Add Acked-by tags from Rob and Krzysztof.
> > - Fix compilation errors.
> > - Link to v3: https://lore.kernel.org/r/20250905-add_video_clk-v3-0-8304c91b8b94@xxxxxxxxxxx
> >
> > Changes in v3:
> > - Rebase with Jerome's latest code base.
> > - Link to v2: https://lore.kernel.org/r/20250814-add_video_clk-v2-0-bb2b5a5f2904@xxxxxxxxxxx
> >
> > Changes in v2:
> > - Removed lcd_an clock tree (previously used in meson series but obsolete in
> > newer chips).
> > - Removed Rob's 'Acked-by' tag due to dt-binding changes (Is it necessary?).
> > - Link to v1: https://lore.kernel.org/r/20250715-add_video_clk-v1-0-40e7f633f361@xxxxxxxxxxx
> >
> > ---
> > Chuan Liu (2):
> >        dt-bindings: clock: add video clock indices for Amlogic S4 SoC
> >        clk: amlogic: add video-related clocks for S4 SoC
> >
> >   drivers/clk/meson/s4-peripherals.c                 | 206 ++++++++++++++++++++-
> >   .../clock/amlogic,s4-peripherals-clkc.h            |  11 ++
> >   2 files changed, 213 insertions(+), 4 deletions(-)
> > ---
> > base-commit: 01f3a6d1d59b8e25a6de243b0d73075cf0415eaf
> > change-id: 20250715-add_video_clk-dc38b5459018
> >
> > Best regards,
> --
> Jerome