Re: [PATCH RESEND v3 4/5] drm/bridge: it6505: modify DP link training work

From: Dmitry Baryshkov
Date: Tue Sep 16 2025 - 06:44:27 EST


On Tue, Sep 16, 2025 at 12:47:44PM +0800, Hermes Wu via B4 Relay wrote:
> From: Hermes Wu <Hermes.wu@xxxxxxxxxx>
>
> The DP link training work include auto training and after
> auto training failed "AUTO_TRAIN_RETRY" times, it switch to
> step training mode.
>
> It will more efficiency that finish link auto training,
> include retry, and step training in a work, rather than
> re-schedule train work when each training fail.
>
> Drop auto_train_retry from it6505 structure,
> and it6505_dump() is remove from link trainig work,
> it takes too much time to read all register area,
> and is not necessary.

Nit: please fix your editor to wrap commit messages on a more typical
boundary (72-75-77 chars).

Otherwise:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>



>
> Signed-off-by: Hermes Wu <Hermes.wu@xxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 40 ++++++++++++++-----------------------
> 1 file changed, 15 insertions(+), 25 deletions(-)
>

--
With best wishes
Dmitry