Re: [RFC PATCH v2] net: add net-device TX clock source selection framework

[Jiri Pirko]

Fri, Aug 29, 2025 at 09:05:02AM +0200, arkadiusz.kubalewski@xxxxxxxxx wrote:
>>From: Mina Almasry <almasrymina@xxxxxxxxxx>
>>Sent: Thursday, August 28, 2025 6:58 PM
>>
>>On Thu, Aug 28, 2025 at 9:50 AM Arkadiusz Kubalewski
>><arkadiusz.kubalewski@xxxxxxxxx> wrote:
>>> ---
>>>  Documentation/netlink/specs/netdev.yaml     |  61 +++++
>>>  drivers/net/ethernet/intel/ice/Makefile     |   1 +
>>>  drivers/net/ethernet/intel/ice/ice.h        |   5 +
>>>  drivers/net/ethernet/intel/ice/ice_lib.c    |   6 +
>>>  drivers/net/ethernet/intel/ice/ice_main.c   |   6 +
>>>  drivers/net/ethernet/intel/ice/ice_tx_clk.c | 100 +++++++
>>> drivers/net/ethernet/intel/ice/ice_tx_clk.h |  17 ++
>>>  include/linux/netdev_tx_clk.h               |  92 +++++++
>>>  include/linux/netdevice.h                   |   4 +
>>>  include/uapi/linux/netdev.h                 |  18 ++
>>>  net/Kconfig                                 |  21 ++
>>>  net/core/Makefile                           |   1 +
>>>  net/core/netdev-genl-gen.c                  |  37 +++
>>>  net/core/netdev-genl-gen.h                  |   4 +
>>>  net/core/netdev-genl.c                      | 287 ++++++++++++++++++++
>>>  net/core/tx_clk.c                           | 218 +++++++++++++++
>>>  net/core/tx_clk.h                           |  36 +++
>>>  tools/include/uapi/linux/netdev.h           |  18 ++
>>>  18 files changed, 932 insertions(+)
>>
>>Consider breaking up a change of this size in a patch series to make it a
>>bit easier for reviewers, if it makes sense to you.
>>
>>--
>>Thanks,
>>Mina
>
>Yes, will surely do for non-RFC submission.

Please, do it always. You request for comment of something you make hard
to read. Does not make sense to me :/


>
>Thank you!
>Arkadiusz