Re: [PATCH v1 1/1] lock_mount(): Remove unused function

From: Andy Shevchenko

Date: Tue Sep 16 2025 - 08:38:09 EST


On Tue, Sep 16, 2025 at 02:17:48PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 16, 2025 at 02:25:37AM +0100, Al Viro wrote:
> > On Mon, Sep 15, 2025 at 06:02:21PM +0200, Andy Shevchenko wrote:
> > > clang is not happy about unused function:
> > >
> > > /fs/namespace.c:2856:20: error: unused function 'lock_mount' [-Werror,-Wunused-function]
> > > 2856 | static inline void lock_mount(const struct path *path,
> > > | ^~~~~~~~~~
> > > 1 error generated.
> > >
> > > Fix the compilation breakage (`make W=1` build) by removing unused function.
> > >
> > > Fixes: d14b32629541 ("change calling conventions for lock_mount() et.al.")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > Folded into commit in question to avoid bisect hazard
>
> Thank you!

It seems similar treatment needs for node_to_mnt_ns() as it's now unused after
the commit 96ff702edaec ("mnt: support ns lookup") if I'm not mistaken.

Should I send a patch?

--
With Best Regards,
Andy Shevchenko