Re: [PATCH v1 4/7] mfd: sec: add support for s2mps16 pmic
From: Lee Jones
Date: Tue Sep 16 2025 - 11:56:12 EST
On Sun, 14 Sep 2025, Ivaylo Ivanov wrote:
> Add support for Samsung's s2mps16 pmic. It's the primary PMIC used by
> exynos8890 devices. It houses regulators (38 LDOs and 11 BUCKs), three
> 32.768KHz clock outputs and an RTC device.
>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> ---
> drivers/mfd/sec-common.c | 10 ++
> drivers/mfd/sec-i2c.c | 16 +++
> drivers/mfd/sec-irq.c | 46 +++++++
> include/linux/mfd/samsung/core.h | 1 +
> include/linux/mfd/samsung/irq.h | 66 ++++++++++
> include/linux/mfd/samsung/s2mps16.h | 195 ++++++++++++++++++++++++++++
> 6 files changed, 334 insertions(+)
> create mode 100644 include/linux/mfd/samsung/s2mps16.h
Looks okay. Once you have the Regulator Ack we can merge this through MFD.
--
Lee Jones [李琼斯]