Re: [PATCH net-next v2] dpll: zl3073x: Allow to use custom phase measure averaging factor
From: Jakub Kicinski
Date: Tue Sep 16 2025 - 18:25:20 EST
On Tue, 16 Sep 2025 20:16:57 +0200 Ivan Vecera wrote:
> >> Add devlink device parameter phase_offset_avg_factor to allow a user
> >> set tune the averaging factor via devlink interface.
> >
> >Is averaging phase offset normal for DPLL devices?
>
> I don't know... I expect that DPLL chips support phase offset
> measurement but probably implementation specific.
Ack, I was hoping Arkadiusz and Vadim could comment what their DPLL
devices do.
> >If it is we should probably add this to the official API.
>
> The problem in case of this Microchip DPLL devices is that this
> parameter is per ASIC. It is common for all DPLL channels
> (devices) inside the chip. That's why I chose devlink.
>
> >If it isn't we should probably default to smallest possible history?
>
> Do you mean the default value?
Yes, but let's wait for others to chime in.