Re: [PATCH V7 3/5] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC

From: Krzysztof Kozlowski
Date: Tue Sep 16 2025 - 20:29:52 EST


On 16/09/2025 16:28, Jishnu Prakash wrote:
>> You cannot have empty spaces in ID constants. These are abstract
>> numbers.
>>
>> Otherwise please point me to driver using this constant.
>
> These constants are for ADC channel numbers, which are fixed in HW.
>
> They are used in this driver: drivers/iio/adc/qcom-spmi-adc5-gen3.c,
> which is added in patch 4 of this series.
>
> They can be found in the array named adc5_gen3_chans_pmic[].

Really? So point me to the line there using ADC5_GEN3_VREF_BAT_THERM.

You responded three weeks after review, this patch goes nowhere and way
you handle upstream work makes it difficult for us and probably for you.

NAK

>
> Thanks,
> Jishnu
>
>>
>> Best regards,
>> Krzysztof
>>
>


Best regards,
Krzysztof