Re: [PATCH] scsi: lpfc: Use int type to store negative error codes
From: Martin K. Petersen
Date: Tue Sep 16 2025 - 22:27:46 EST
On Thu, 04 Sep 2025 21:23:51 +0800, Qianfeng Rong wrote:
> Change the 'ret' variable in lpfc_sli4_issue_wqe() from uint32_t to int,
> as it needs to store either negative error codes or zero returned by
> lpfc_sli4_wq_put().
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
>
> [...]
Applied to 6.18/scsi-queue, thanks!
[1/1] scsi: lpfc: Use int type to store negative error codes
https://git.kernel.org/mkp/scsi/c/5cffc679ad1d
--
Martin K. Petersen