Re: [PATCH 2/3] dt-bindings: Add CTF2301 devicetree bindings
From: Troy Mitchell
Date: Wed Sep 17 2025 - 02:41:00 EST
Hi Rob, Thanks for your review.
On Tue, Sep 16, 2025 at 08:52:16AM -0500, Rob Herring wrote:
> On Tue, Sep 16, 2025 at 12:46:45PM +0800, Troy Mitchell wrote:
> > Add dt-binding for the hwmon driver of Sensylink's CTF2301 chip.
> >
> > Signed-off-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> > ---
> > .../bindings/hwmon/sensylink,ctf2301.yaml | 49 ++++++++++++++++++++++
> > 1 file changed, 49 insertions(+)
> > +description: |
> > + The CTF2301B is an I2C/SMBus compatible device featuring:
> > + - One local temperature sensor with ±0.5°C accuracy and 0.0625°C resolution.
> > + - One remote temperature sensor for external diode-connected transistors, offering ±1°C accuracy and 0.125°C resolution (temperature range: -40°C to +125°C).
>
> Wrap at 80 chars.
I'll fix it in the next version.
>
> > + - An integrated PWM fan controller.
> > + - A 1-channel fan speed monitor (TACH input) for RPM measurement.
> > +
> > + Datasheets:
> > + https://www.sensylink.com/upload/1/net.sensylink.portal/1689557281035.pdf
> > +
> > +properties:
> > + compatible:
> > + const:
> > + - sensylink,ctf2301
I will fix this warning in the next version (your robot reported)
- Troy
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ctf2301@4c {
> > + compatible = "sensylink,ctf2301";
> > + reg = <0x4c>;
> > + };
> > + };
> >
> > --
> > 2.51.0
> >