Re: [PATCH net-next] net: phy: micrel: Add Fast link failure support for lan8842

[Horatiu Vultur]

The 09/16/2025 14:53, Andrew Lunn wrote:
> 
> On Tue, Sep 16, 2025 at 09:34:27AM +0200, Horatiu Vultur wrote:
> > The 09/15/2025 14:42, Andrew Lunn wrote:
> >
> > Hi Andrew,
> >
> > >
> > > > +/**
> > > > + * LAN8814_PAGE_PCS - Selects Extended Page 0.
> > > > + *
> > > > + * This page appaers to control the fast link failure and there are different
> 
> > And the reason why I say it 'appears' is because I have seen most of the
> > registers are for debug and some timers.
> 
> So maybe change the comment to
> 
>         This page contains timers and debug registers...
> 
> It does not matter if the document is public or not, the description
> is then correct and does not give the suggestion it is guesswork.

Yes, I will change this in the next version.

> 
>         Andrew

-- 
/Horatiu