Re: [PATCH] dt-bindings: i2c: spacemit: extend and validate all properties

From: Troy Mitchell
Date: Wed Sep 17 2025 - 03:51:02 EST


On Wed, Sep 17, 2025 at 11:38:13AM +0800, Yixun Lan wrote:
> Extend the K1 I2C properties by including generic i2c-controller schema.
> and this will enable it to do the DT validation check later.
>
> Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx>
> ---
> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: i2c@d401d800: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'pmic@41' were unexpected)
>
> Link: https://lore.kernel.org/all/20250825172057.163883-6-elder@xxxxxxxxxxxx/ [1]
> ---
> Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> index 3d6aefb0d0f185ba64e414ac7f5b96cd18659fd3..226c600deae142413277117e25baae09f0918381 100644
> --- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> @@ -9,6 +9,9 @@ title: I2C controller embedded in SpacemiT's K1 SoC
> maintainers:
> - Troy Mitchell <troymitchell988@xxxxxxxxx>
>
> +allOf:
> + - $ref: /schemas/i2c/i2c-controller.yaml#
> +
oops, I forgot to add this..
Thanks for your fix!

Reviewed-by: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
> properties:
> compatible:
> const: spacemit,k1-i2c
>
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250917-01-k1-i2c-schema-faf6715d7b88
>
> Best regards,
> --
> Yixun Lan
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-riscv