Re: [PATCH v3 3/4] ARM: dma-mapping: Switch to physical address mapping callbacks

[Jason Gunthorpe]

On Wed, Sep 17, 2025 at 01:36:44PM +0300, Leon Romanovsky wrote:
> On Tue, Sep 16, 2025 at 03:46:17PM -0300, Jason Gunthorpe wrote:
> > On Tue, Sep 16, 2025 at 10:32:06AM +0300, Leon Romanovsky wrote:
> > > +	if (!dev->dma_coherent &&
> > > +	    !(attrs & (DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_MMIO)))
> > > +		__dma_page_cpu_to_dev(phys_to_page(phys), offset, size, dir);
> > 
> > I'd keep going and get rid of the page here too, maybe as a second
> > patch in this series:
> 
> Thanks, it is always unclear how far to go with cleanups.

IMHO to maximally support what Matthew is working on I'd remove all
the struct page things and prefer the pfn/phys variations from the MM
side.

After this the only thing left is the kmap_high_get(), and I'm not
sure what becomes of WANT_PAGE_VIRTUAL in a memdesc world..

Jason