Re: [PATCH v4 1/5] printk: nbcon: Export console_is_usable

[Marcos Paulo de Souza]

On Wed, 2025-09-17 at 10:57 +0200, Petr Mladek wrote:
> On Mon 2025-09-15 08:20:30, Marcos Paulo de Souza wrote:
> > The helper will be used on KDB code in the next commits.
> > 
> > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
> 
> Nit :-)
> 
> The ordering of the tags is important. It defines the timeline of
> the related actions.
> 
> The above ordering might be understood as that Petr reviewed
> an older version of patch. But it was later modified by Marcos.
> 
> The expected ordering is:
> 
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
> 
> It means that Macros developed a patch and Petr reviewed it.
> The patch was not longer modified.
> 
> Note the Reviewed-by tag might be preserved even when Marcos
> later did some cosmetic changes, e.g. fixed a typo, formatting,
> or rebased.

Got it. I used b4 prep --update-trailers, and it added the Reviewed-by
before my Sign-off. But still, this patch didn't change since the last
submission, so I thought that it would be ok.

But I'll double check next time.

> 
> Best Regards,
> Petr
> 
> PS: There is no need to send v5 just because of this. I could fix
>     it when committing the patch...