Re: [PATCH net-next v3 1/3] net: stmmac: enhance VLAN protocol detection for GRO

[Simon Horman]

On Tue, Sep 16, 2025 at 02:48:06PM +0200, Konrad Leszczynski wrote:
> From: Piotr Warpechowski <piotr.warpechowski@xxxxxxxxx>
> 
> Enhance protocol extraction in stmmac_has_ip_ethertype() by introducing
> MAC offset parameter and changing:
> 
> __vlan_get_protocol() ->  __vlan_get_protocol_offset()
> 
> Add correct header length for VLAN tags, which enable Generic Receive
> Offload (GRO) in VLAN.
> 
> Co-developed-by: Karol Jurczenia <karol.jurczenia@xxxxxxxxx>
> Signed-off-by: Karol Jurczenia <karol.jurczenia@xxxxxxxxx>
> Reviewed-by: Konrad Leszczynski <konrad.leszczynski@xxxxxxxxx>
> Reviewed-by: Sebastian Basierski <sebastian.basierski@xxxxxxxxx>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
> Signed-off-by: Piotr Warpechowski <piotr.warpechowski@xxxxxxxxx>

Hi Konrad,

As you are sending these patches, your Signed-off-by line is needed.
I would suggest at the end of the tags. And when present,
you can drop your Reviewed-by tag (it is implied).

Otherwise this patch looks good to me.

Same for the other patches in this series.

-- 
pw-bot: changes-requested