Re: [RFC PATCH] PCI: Add quirk to always map ivshmem as write-back

[Borislav Petkov]

On Mon, Sep 15, 2025 at 05:43:33PM +1000, Alexey Kardashevskiy wrote:
> yeah, sadly, there is one - people are actually using it, for, like,
> a decade, and not exactly keen on changing those user space tools :) Hence
> "RFC".

Then this commit message needs a lot more explanation as it is something the
kernel should support apparently when running as a guest...

But then, if it has been used for a decade already, why do you need that quirk
now? No one has noticed in 10 years time...?

> > >   	else
> > > +	else if (!(pci_resource_flags(pdev, bar) & IORESOURCE_CACHEABLE))
> > 	^^^^^^
> > 
> > This can't build.
> 
> Why? Compiles and works just fine.

Here's a more detailed explanation:

https://lore.kernel.org/r/202506131608.QlkxUPnI-lkp@xxxxxxxxx

You haven't replaced the "else" with "else if" but left it there.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette