Re: [PATCH v2] cleanup: Fix "unused function" warnings with conditional guards

From: dan.j.williams

Date: Wed Sep 17 2025 - 19:22:01 EST


Andrew Morton wrote:
[..]
> > Alternatively just merge the suggestion in [1], and call it a day.
> >
> > Link: http://lore.kernel.org/20250813152142.GP4067720@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [1]
>
> lgtm, unless we think this (your) patch improves the code for other reasons?

The tl;dr above is that the warning could have small value, but probably
not greater than the overall benefit to Linux to stop bothering folks
with this low-value warning by default at W=1.

So I am over the sunk costs, and moving this warning to W=2 is the way
to go.