Re: [PATCH] HID: hid-ntrig: Fix potential memory leak in ntrig_report_version()

[Masami Ichikawa]

Thank you for the review.

On Wed, Sep 17, 2025 at 4:46 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> …
> > It is safe to move the kmalloc() call after the hid_is_usb() check to avoid
> > unnecessary allocation and potential memory leak.
>
> * See also:
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc6#n94
>
> * How do you think about to increase the application of scope-based resource management?
>   https://elixir.bootlin.com/linux/v6.17-rc6/source/include/linux/slab.h#L476
>

I think using the DEFINE_FREE macro simplifies cleanup, especially
when an error occurs.

> * Can a summary phrase like “Prevent memory leak in ntrig_report_version()”
>   be nicer?
>

I see. I will rewrite commit log.

>
> Regards,
> Markus


Regards,
-- 
Masami Ichikawa