Re: [PATCH v3 1/5] dt-bindings: touchscreen: convert bu21013 bindings to json schema

From: Krzysztof Kozlowski
Date: Wed Sep 17 2025 - 22:13:12 EST


On Sun, Sep 14, 2025 at 10:37:52PM +0200, Dario Binacchi wrote:
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/bu21013.yaml b/Documentation/devicetree/bindings/input/touchscreen/bu21013.yaml
> new file mode 100644
> index 000000000000..aeb581fcaf29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/bu21013.yaml

Filename based on compatible, so rohm,bu21013.yaml

> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/bu21013.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rohm BU21013 touchscreen
> +
> +description:
> + Rohm BU21013 I2C driven touchscreen controller.
> +
> +maintainers:
> + - Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> +
> +allOf:
> + - $ref: touchscreen.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - rohm,bu21013_tp
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO resetting the chip

Drop description, obvious.

> +
> + touch-gpios:
> + maxItems: 1
> + description: GPIO registering a touch event.
> +
> + avdd-supply:
> + description: Phandle to the regulator supplying the analog circuit.

Analog circuit supply.
(rest is redundant, it cannot be something else than phandle)

With these fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof