Re: [PATCH v9 08/10] fs/resctrl: Modify rdt_parse_data to pass mode and CLOSID

From: Reinette Chatre

Date: Thu Sep 18 2025 - 01:44:49 EST


Hi Babu,

nit:
Subject: fs/resctrl: Modify struct rdt_parse_data to pass mode and CLOSID

On 9/2/25 3:41 PM, Babu Moger wrote:
> parse_cbm() require resource group mode and CLOSID to validate the Capacity
> Bit Mask (CBM). It is passed via struct rdtgroup in struct rdt_parse_data.
>
> The io_alloc feature also uses CBMs to indicate which portions of cache are
> allocated for I/O traffic. The CBMs are provided by user space and need to
> be validated the same as CBMs provided for general (CPU) cache allocation.
> parse_cbm() cannot be used as-is since io_alloc does not have rdtgroup
> context.
>
> Pass the resource group mode and CLOSID directly to parse_cbm() via struct
> rdt_parse_data, instead of through the rdtgroup struct, to facilitate
> calling parse_cbm() to verify the CBM of the io_alloc feature.
>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> ---

With Subject change:

| Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette