Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode
From: Anup Kulkarni
Date: Thu Sep 18 2025 - 02:35:13 EST
On Wed, Sep 17, 2025 at 4:45 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Sep 16, 2025 at 03:09:57PM +0530, Anup Kulkarni wrote:
> > If uart_get_rs485() fails, the driver returns without detaching
> > the PM domain list.
> >
> > Fix the error handling path in uart_get_rs485_mode() to ensure the
> > PM domain list is detached before exiting.
> >
> > Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Anup Kulkarni <anup.kulkarni@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/tty/serial/qcom_geni_serial.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I've taken
> https://lore.kernel.org/r/20250917010437.129912-2-krzysztof.kozlowski@xxxxxxxxxx
> instead, so this shouldn't be needed anymore.
>
Agree. It's not required now.
> thanks,
>
> greg k-h
thanks,
Anup