Re: [PATCH 2/3] arm64: dts: qcom: Rework X1-based Asus Zenbook A14's displays

[Aleksandrs Vinarskis]

On Friday, September 12th, 2025 at 18:52, Aleksandrs Vinarskis <alex@xxxxxxxxxxxxx> wrote:

> 
> 
> 
> 
> 
> 
> 
> On Friday, September 12th, 2025 at 12:44, Konrad Dybcio konrad.dybcio@xxxxxxxxxxxxxxxx wrote:
> 
> > On 9/8/25 8:45 PM, Aleksandrs Vinarskis wrote:
> > 
> > > The laptop comes in two variants:
> > > 
> > > * UX3407RA, higher end, FHD+ OLED or WOXGA+ OLED panels
> > > * UX3407QA, lower end, FHD+ OLED or FHD+ LCD panels
> > > 
> > > Even though all three panels work with "edp-panel", unfortunately the
> > > brightness adjustmenet of LCD panel is PWM based, requiring a dedicated
> > > device-tree. Convert "x1p42100-asus-zenbook-a14.dts" into ".dtsi" to
> > > allow for this split, introduce new LCD variant. Leave current variant
> > > without postfix and with the unchanged model name, as some distros
> > > (eg. Ubuntu) rely on this for automatic device-tree detection during
> > > kernel installation/upgrade.
> > > 
> > > As dedicated device-tree is required, update compatibles of OLED
> > > variants to correct ones. Keep "edp-panel" as fallback, since it is
> > > enough to make the panels work.
> > > 
> > > Signed-off-by: Aleksandrs Vinarskis alex@xxxxxxxxxxxxx
> > > Co-developed-by: Jens Glathe jens.glathe@xxxxxxxxxxxxxxxxxxxxxx
> > > Signed-off-by: Jens Glathe jens.glathe@xxxxxxxxxxxxxxxxxxxxxx
> > > ---
> > 
> > [...]
> > 
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtsi
> > > @@ -0,0 +1,141 @@
> > > +// SPDX-License-Identifier: BSD-3-Clause
> > > +/*
> > > + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
> > > + * Copyright (c) 2025 Aleksandrs Vinarskis alex@xxxxxxxxxxxxx
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "x1p42100.dtsi"
> > > +#include "x1-asus-zenbook-a14.dtsi"
> > > +
> > > +/delete-node/ &pmc8380_6;
> > > +/delete-node/ &pmc8380_6_thermal;
> > > +
> > > +/ {
> > > + model = "ASUS Zenbook A14 (UX3407QA)";
> > 
> > 'model' in .dtsi is 'eeeeh'
> 
> 
> Followed example of Thinkpad t14s and CRD, as they set it to
> 'default' in .dtsi, and overwrite in .dts. Could fix it starting
> with Zenbook here, but in this case probably makes sense to also
> drop 'model' from higher level 'x1-asus-zenbook-a14.dtsi' as well?

Hi Konrad,

Any comments on this?

Alex

> 
> > [...]
> > 
> > > +&remoteproc_adsp {
> > > + firmware-name = "qcom/x1p42100/ASUSTeK/zenbook-a14/qcadsp8380.mbn",
> > > + "qcom/x1p42100/ASUSTeK/zenbook-a14/adsp_dtbs.elf";
> > > +
> > 
> > are both of the aforementioned variants' firmwares the same?
> 
> 
> Yes, Asus doesn't distinguish BSP packages between options (displays
> in this case) but only X1E (UX3407RA) vs X1(P) (UX3407QA).
> 
> > Konrad