Re: [PATCH v7 2/2] ethernet: eswin: Add eic7700 ethernet driver

[Maxime Chevallier]

Hi,

On 18/09/2025 14:30, weishangjuan@xxxxxxxxxxxxxxxxxx wrote:
> From: Shangjuan Wei <weishangjuan@xxxxxxxxxxxxxxxxxx>
>
> Add Ethernet controller support for Eswin's eic7700 SoC. The driver
> implements hardware initialization, clock configuration, delay
> adjustment functions based on DWC Ethernet controller, and supports
> device tree configuration and platform driver integration.
>
> Signed-off-by: Zhi Li <lizhi2@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Shangjuan Wei <weishangjuan@xxxxxxxxxxxxxxxxxx>
> ---
>   drivers/net/ethernet/stmicro/stmmac/Kconfig   |  11 +
>   drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
>   .../ethernet/stmicro/stmmac/dwmac-eic7700.c   | 230 ++++++++++++++++++
>   3 files changed, 242 insertions(+)
>   create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index 67fa879b1e52..a13b15ce1abd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -67,6 +67,17 @@ config DWMAC_ANARION
>
>   	  This selects the Anarion SoC glue layer support for the stmmac driver.
>
> +config DWMAC_EIC7700
> +	tristate "Support for Eswin eic7700 ethernet driver"
> +	select CRC32
> +	select MII

Seems like CRC32 and MII are already selected by STMMAC_ETH. I guess 
this is inspired by CONFIG_DWMAC_DWC_QOS_ETH that also seems to have 
these unnecessary dependencies.

Maxime