Re: [PATCH] arch_topology: Fix incorrect error check in topology_parse_cpu_capacity()

From: Markus Elfring

Date: Tue Sep 23 2025 - 03:46:50 EST



> returns NULL. Replace with IS_ERR_OR_NULL() which correctly identifies
> only valid pointers, ensuring clk_get_rate() is called only with valid
> clock objects.

* Can the change description be refined based on documented macro call properties?
https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/err.h#L101-L123

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?


Regards,
Markus