Re: [PATCH net-next v6 1/1] Documentation: net: add flow control guide and document ethtool API

[Simon Horman]

On Mon, Sep 22, 2025 at 01:21:23PM +0200, Oleksij Rempel wrote:

...

> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 7a7594713f1f..7587a00af49d 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -864,7 +864,9 @@ attribute-sets:
>  
>    -
>      name: pause-stat
> +    doc: Statistics counters for link-wide PAUSE frames (IEEE 802.3 Annex 31B).
>      attr-cnt-name: __ethtool-a-pause-stat-cnt
> +    enum-name: ethtool-a-pause-stat
>      attributes:
>        -
>          name: unspec
> @@ -875,13 +877,17 @@ attribute-sets:
>          type: pad
>        -
>          name: tx-frames
> +        doc: Number of PAUSE frames transmitted.
>          type: u64
>        -
>          name: rx-frames
> +        doc: Number of PAUSE frames received.
>          type: u64
>    -
>      name: pause
> +    doc: Parameters for link-wide PAUSE (IEEE 802.3 Annex 31B).
>      attr-cnt-name: __ethtool-a-pause-cnt
> +    enum-name: ethtool-a-pause
>      attributes:
>        -
>          name: unspec

Hi Oleksij,

I believe it is due to the enum-name changes above, but in any case
this patch alters the output produced by tools/net/ynl/ynl-regen.sh -f
and those changes need to be included in this commit (or the commit changes
so the out put of ynl-gregen.sh is unchanged).

In short, in it's current form, this commit seems to be missing:

diff --git a/include/uapi/linux/ethtool_netlink_generated.h b/include/uapi/linux/ethtool_netlink_generated.h
index e3b881346..4a8eec944 100644
--- a/include/uapi/linux/ethtool_netlink_generated.h
+++ b/include/uapi/linux/ethtool_netlink_generated.h
@@ -375,7 +375,7 @@ enum {
 	ETHTOOL_A_COALESCE_MAX = (__ETHTOOL_A_COALESCE_CNT - 1)
 };

-enum {
+enum ethtool_a_pause_stat {
 	ETHTOOL_A_PAUSE_STAT_UNSPEC,
 	ETHTOOL_A_PAUSE_STAT_PAD,
 	ETHTOOL_A_PAUSE_STAT_TX_FRAMES,
@@ -385,7 +385,7 @@ enum {
 	ETHTOOL_A_PAUSE_STAT_MAX = (__ETHTOOL_A_PAUSE_STAT_CNT - 1)
 };

-enum {
+enum ethtool_a_pause {
 	ETHTOOL_A_PAUSE_UNSPEC,
 	ETHTOOL_A_PAUSE_HEADER,
 	ETHTOOL_A_PAUSE_AUTONEG,

-- 
pw-bot: changes-requested