Re: [PATCH] KVM: x86: skip userspace IOAPIC EOI exit when Directed EOI is enabled

[Khushit Shah]

Thanks for the very detailed review.

> On 23 Sep 2025, at 3:21 AM, Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> 
> Don't bother sending a v2, at least not yet.  I'll follow-up with various folks
> to try and figure out the least awful way to get out of this mess, and will
> probably post a v2 with a CAP and/or quirk.

I am happy to help with v2!

Reported-by: Khushit Shah <khushit.shah@xxxxxxxxxxx>
Tested-by: Khushit Shah <khushit.shah@xxxxxxxxxxx>

> On 23 Sep 2025, at 3:21 AM, Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> 
> /* Request a KVM exit to inform the userspace IOAPIC. */
> if (irqchip_split(apic->vcpu->kvm)) {
> + /*
> +  * Don't exit to userspace if the guest has enabled Directed
> +  * EOI, a.k.a. Suppress EOI Broadcasts, in which the local APIC
> +  * doesn't broadcast EOIs (the the guest must EOI the target
> +  * I/O APIC(s) directly).
> +  */
> +

Nit: small typo in the comment (“the the”).