Re: [PATCH iproute2-next 1/3] iplink_can: fix coding style for pointer format
From: Vincent Mailhol
Date: Mon Sep 22 2025 - 22:07:44 EST
On 23/09/2025 at 07:10, Stephen Hemminger wrote:
> On Sun, 21 Sep 2025 16:32:30 +0900
> Vincent Mailhol <mailhol@xxxxxxxxxx> wrote:
>
>> checkpatch.pl complains about the pointer symbol * being attached to the
>> type instead of being attached to the variable:
>>
>> ERROR: "foo* bar" should be "foo *bar"
>> #85: FILE: ip/iplink_can.c:85:
>> + const char* name)
>>
>> ERROR: "foo* bar" should be "foo *bar"
>> #93: FILE: ip/iplink_can.c:93:
>> +static void print_ctrlmode(enum output_type t, __u32 flags, const char* key)
>>
>> Fix those two warnings.
>>
>> Signed-off-by: Vincent Mailhol <mailhol@xxxxxxxxxx>
>> ---
>
> This is ok, to fix.
With the other two patches being Nack-ed, we are only left with this one in the
series.
Do you want me to resend or do you prefer to directly cherry pick this one?
Yours sincerely,
Vincent Mailhol