Re: [PATCH iproute2-next 3/3] iplink_can: factorise the calls to usage()
From: Stephen Hemminger
Date: Mon Sep 22 2025 - 18:09:25 EST
On Sun, 21 Sep 2025 16:32:32 +0900
Vincent Mailhol <mailhol@xxxxxxxxxx> wrote:
> usage() is called either if the user passes the "help" argument or passes
> an invalid argument.
>
> Factorise those two cases together.
>
> This silences below checkpatch.pl warning:
>
> WARNING: else is not generally useful after a break or return
> #274: FILE: ip/iplink_can.c:274:
> + return -1;
> + } else {
>
> Signed-off-by: Vincent Mailhol <mailhol@xxxxxxxxxx>
> ---
Not accepting most checkpatch stuff in iproute2.
Better to not have code churn