Re: [PATCH v5 08/12] gpio: add QIXIS FPGA GPIO controller
From: Bartosz Golaszewski
Date: Mon Sep 22 2025 - 10:39:51 EST
On Mon, 22 Sep 2025 16:24:23 +0200, Ioana Ciornei <ioana.ciornei@xxxxxxx> said:
> Add support for the GPIO controller found on some QIXIS FPGAs in
> Layerscape boards such as LX2160ARDB and LS1046AQDS. This driver is
> using gpio-regmap.
>
> A GPIO controller has a maximum of 8 lines (all found in the same
> register). Even within the same controller, the GPIO lines' direction is
> fixed, which mean that both input and output lines are found in the same
> register. This is why the driver also passed to gpio-regmap the newly
> added .fixed_direction_output bitmap to represent the true direction of
> the lines.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> Changes in v2:
> - Use the newly added .fixed_direction_output bitmap representing
> the fixed direction of the GPIO lines.
> Changes in v3:
> - Remove 'drivers' from the commit title.
> - Remove the qixis_cpld_gpio_type enum since its not needed.
> - Remove the NULL check for device_get_match_data().
> - Use a bitmap declared on the stack as the config field passed to
> gpio-regmap.
> Changes in v4:
> - none
> Changes in v5:
> - none
>
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>