Re: [PATCH v2] cleanup: Fix "unused function" warnings with conditional guards

From: Andy Shevchenko

Date: Mon Sep 22 2025 - 02:33:34 EST


On Thu, Sep 18, 2025 at 12:26:28PM -0700, dan.j.williams@xxxxxxxxx wrote:
> Andy Shevchenko wrote:
> > On Wed, Sep 17, 2025 at 04:21:07PM -0700, dan.j.williams@xxxxxxxxx wrote:
> > > Andrew Morton wrote:

[..]

> > > > > Alternatively just merge the suggestion in [1], and call it a day.
> > > > >
> > > > > Link: http://lore.kernel.org/20250813152142.GP4067720@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [1]
> > > >
> > > > lgtm, unless we think this (your) patch improves the code for other reasons?
> > >
> > > The tl;dr above is that the warning could have small value, but probably
> > > not greater than the overall benefit to Linux to stop bothering folks
> > > with this low-value warning by default at W=1.
> > >
> > > So I am over the sunk costs, and moving this warning to W=2 is the way
> > > to go.
> >
> > Can somebody add a fix so, we have v6.17 able to be built with `make W=1`, please?
>
> Andy, might you have time to take Peter's proposed diff and wrap it with
> a changelog for Andrew to pull?

I will try my best, thanks!


--
With Best Regards,
Andy Shevchenko