Re: [PATCH v2 00/11] x86-android-tablets: convert to use GPIO references

[Hans de Goede]

Hi Dmitry,

On 19-Sep-25 11:21 PM, Dmitry Torokhov wrote:
> Hi Hans,
> 
> On Fri, Sep 19, 2025 at 09:53:53PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 11-Aug-25 4:22 AM, Dmitry Torokhov wrote:
>>> This series came about because now software nodes can be used to
>>> describe GPIOs (via PROPERTY_ENTRY_GPIO() macros) and I would like to
>>> eventually get rid of gpio_keys_platform_data structure.
>>>
>>> So while I was doing the conversions from GPIO_LOOKUP() tables for
>>> gpio_keys devices I decided to convert the rest of them as well. Maybe
>>> some time in the future we can drop support for GPIO_LOOKUP() and rely
>>> on device properties exclusively.
>>>
>>> This is completely untested.
>>>
>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>>
>> Thank you for this series. While reviewing this I've found
>> a couple of issues. I've fixed these in my own tree and
>> I'll send out a v3 with this fixed + some extra patches.
>>
>> The issues which I've found and fixed are:
>>
>> - lenovo_yoga_tab2_830_1050_init_codec() is missing a pinctrl_put()
>>   in error-exit paths after the pinctrl_get_select() succeeds
>>
>> - Adding a swnode to the yt3 spi device changes the name of the SPI/codec
>>   device and the sound/soc/intel/boards/bytcr_wm5102.c machine driver looks
>>   up the code by name, update the machine driver to use the new name.
>>
>> - In the "convert Yoga Tab2 fast charger to GPIO references" references
>>   the fwnode is added to the wrong device. The node should be added to
>>   the "serial0-0" device but that gets instantiated by
>>   drivers/platform/x86/lenovo/yoga-tab2-pro-1380-fastcharger.c
>>   I've made yoga-tab2-pro-1380-fastcharger.c propagate the fwnode set on
>>   the platform-device to the serdev it creates to fix this.
>>
>> - Fix the commit message of "platform/x86: x86-android-tablets: convert
>>   gpio_keys devices to GPIO references" which contained a stray reference
>>   to wm5102.
> 
> Thank you Hans for looking over the series and fixing up all the issues
> that I introduced.

You're welcome and thank you for the reviews on the new patches.

Regards,

Hans