Re: [PATCH 08/10] gpu: nova-core: falcon: Add support to check if RISC-V is active

[Timur Tabi]

On Wed, Aug 27, 2025 at 3:28 AM Alistair Popple <apopple@xxxxxxxxxx> wrote:
>
> +register!(NV_PRISCV_RISCV_CPUCTL @ PFalconBase[0x00001388] {
> +    7:7     active_stat as bool;
> +    0:0     halted as bool;
> +});

Two more things I've noticed:

1) I think the convention is to list the bits in increase position.
That is, 'active_stat' should be on the line below 'halted''

2) I think that this should actually be PFalcon2Base[0x00000388]