Re: [PATCH] drm/sched/tests: Remove relict of done_list

From: Philipp Stanner

Date: Fri Sep 19 2025 - 08:11:36 EST


On Fri, 2025-09-19 at 08:33 +0100, Tvrtko Ursulin wrote:
>
> On 19/09/2025 07:44, Philipp Stanner wrote:
> > A rework of the scheduler unit tests removed the done_list. That list is
> > still mentioned in the mock test header.
> >
> > Remove that relict.
> >
> > Fixes: 4576de9b7977 ("drm/sched/tests: Implement cancel_job() callback")
> > Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/scheduler/tests/sched_tests.h | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/tests/sched_tests.h b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> > index 7f31d35780cc..553d45abd057 100644
> > --- a/drivers/gpu/drm/scheduler/tests/sched_tests.h
> > +++ b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> > @@ -31,9 +31,8 @@
> >    *
> >    * @base: DRM scheduler base class
> >    * @test: Backpointer to owning the kunit test case
> > - * @lock: Lock to protect the simulated @hw_timeline, @job_list and @done_list
> > + * @lock: Lock to protect the simulated @hw_timeline and @job_list
> >    * @job_list: List of jobs submitted to the mock GPU
> > - * @done_list: List of jobs completed by the mock GPU
> >    * @hw_timeline: Simulated hardware timeline has a @context, @next_seqno and
> >    * @cur_seqno for implementing a struct dma_fence signaling the
> >    * simulated job completion.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxx>

Applied to drm-misc-next

Thx
P.

>
> Regards,
>
> Tvrtko
>