Re: [PATCH 2/2] dts: aspeed: Add a dts for the nvidia msx4 hpm

[Andrew Lunn]

> +// bootloader takes care of proper mac delays for now.
> +// phy-mode is here to prevent breakage once the aspeed
> +// mac driver is fixed.
> +&mac0 {
> +	phy-mode = "rgmii-id";

Just for my understanding, by "bootloader takes care of proper mac
delays for now" you mean you have a 'hacked' bootloader which no
longer adds delays, unlike the stock aspeed bootloader which does add
delays? Because otherwise, i don't see how rgmii-id will work.

> +	phy-handle = <&ethphy3>;
> +	max-speed = <1000>;

RGMII cannot do more than 1G, so max-speed is pointless.

	Andrew