Re: [PATCH] coresight: Fix data argument to coresight_enable_helpers

[Jie Gan]

On 9/19/2025 6:18 AM, Carl Worth wrote:
> Jie Gan <jie.gan@xxxxxxxxxxxxxxxx> writes:
> > I dont think we can change back to sink_data since we introduced
> > coresight_path to wrap 'data' which is needed by the path.
> >
> > I suggest you to add the struct perf_output_handle to the
> > coresight_path, then retrieving it with data->perf_handle in
> > tmc_etr_get_buffer.
> ...
> > We can assign the perf_output_handle to the coresight_path after we
> > constructed the coresight_path in perf mode.
>
> Thanks. That much makes sense to me, and I'll put together a patch along
> those lines.
>
> But, further: with core coresight code assembling into the path all the
> data that is necessary, is there any reason to be using void* in these
> enable/disable functions?

In my opinion, yes, we can change void * to coresight_path * for 
helper's enable/disable functions since we have everything in path so 
the cast is not necessary now.

> Could we also change these functions to accept a coresight_path* and
> actually get some compiler help at finding mistakes like the one we're
> fixing here?

That's the only benefit in my mind so far.

Thanks,
Jie

> -Carl