Re: [PATCH v1 2/4] perf test: Don't leak workload gopipe in PERF_RECORD_*

[Ian Rogers]

On Tue, Sep 16, 2025 at 6:06 PM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> On Tue, Sep 16, 2025 at 12:08:58PM -0700, Ian Rogers wrote:
> > On Tue, Sep 16, 2025 at 12:04 PM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > > On Thu, Aug 21, 2025 at 03:18:32PM -0700, Ian Rogers wrote:
> > > > The test starts a workload and then opens events. If the events fail
> > > > to open, for example because of perf_event_paranoid, the gopipe of the
> > > > workload is leaked and the file descriptor leak check fails when the
> > > > test exits. To avoid this cancel the workload when opening the events
> > > > fails.
>
> > > > Before:
> > > > ```
> > > > $ perf test -vv 7
> > > >   7: PERF_RECORD_* events & perf_sample fields:
> > > > --- start ---
>
> > > ⬢ [acme@toolbx perf-tools-next]$ patch -p1 < b
> > > patching file tools/perf/tests/perf-record.c
> > > Hunk #1 succeeded at 130 (offset 15 lines).
> > > Hunk #2 succeeded at 142 with fuzz 1 (offset 15 lines).
> > > Hunk #3 succeeded at 154 (offset 15 lines).
> > > Hunk #4 succeeded at 167 (offset 15 lines).
> > > ⬢ [acme@toolbx perf-tools-next]$
> > > ⬢ [acme@toolbx perf-tools-next]$ git log --oneline -5 tools/perf/tests/perf-record.c
> > > 576bd7a8c90c48e9 (x1/perf-tools-next, x1/HEAD, five/perf-tools-next, five/HEAD) perf tests record: Update testcase to fix usage of affinity for machines with #CPUs > 1K
> > > b4c658d4d63d6149 perf target: Remove uid from target
> > > dc6d2bc2d893a878 perf sample: Make user_regs and intr_regs optional
> > > fd8d5a3b076c033f perf tests: Add missing event.h include
> > > 9823147da6c893d9 perf tools: Move 'struct perf_sample' to a separate header file to disentangle headers
> > > ⬢ [acme@toolbx perf-tools-next]$
>
> > > Can you please check that it is still ok?
>
> > > I processed the first in the series and now I'm going thru the other
> > > two.
>
> > Thanks Arnaldo! I'm not seeing the patch on:
> > https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=tmp.perf-tools-next
>
> Sorry, I thought I had pushed it earlier, should be there now.
>
> > I'm happy to check.
>
> Thanks!

Not seeing it, but I see the first patch. In any case I'll rebase and
send as a v2.

Thanks,
Ian

> - Arnaldo