Re: [PATCH v2 04/33] block: use extensible_ioctl_valid()

From: Jan Kara

Date: Thu Sep 18 2025 - 09:18:04 EST


Christian, this bug still seems to be present in your vfs.all branch. Can
you please fix it up? Thanks!

Honza

On Tue 16-09-25 16:40:10, Dan Carpenter wrote:
> Yeah, the:
>
> if (extensible_ioctl_valid(cmd, FS_IOC_GETLBMD_CAP, LBMD_SIZE_VER0))
> return -ENOIOCTLCMD;
>
> test is inverted... It should be if (!valid) return instead of if (valid)
> return;
>
> regards,
> dan carpenter
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR