Re: [PATCH] ASoC: pxa: Return -EOPNOTSUPP instead of -EINVAL

[Thorsten Blum]

On 18. Sep 2025, at 13:33, Mark Brown wrote:
> On Thu, Sep 18, 2025 at 01:21:02PM +0200, Thorsten Blum wrote:
> 
>> Return -EOPNOTSUPP from mmp_sspa_set_dai_sysclk() instead of -EINVAL for
>> unsupported clock ids, and remove the obsolete comment.
> 
> Why?

The comment says "not supported yet", so returning -EOPNOTSUPP (or
-ENOTSUPP) reflects this more accurately than -EINVAL, unless I
misunderstood something.

Feel free to ignore this patch if it's inconsistent with how other
drivers handle this (I didn't check tbh).

Thanks,
Thorsten