RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible

[Pritam Manohar Sutar]

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 18 September 2025 08:13 AM
> To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>
> Cc: vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; robh@xxxxxxxxxx;
> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx;
> andre.draszik@xxxxxxxxxx; peter.griffin@xxxxxxxxxx; kauschluss@xxxxxxxxxxx;
> ivo.ivanov.ivanov1@xxxxxxxxx; igor.belwon@xxxxxxxxxxxxxxxxxxxxxxxxxx;
> m.szyprowski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux-
> phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-
> soc@xxxxxxxxxxxxxxx; rosa.pila@xxxxxxxxxxx; dev.tailor@xxxxxxxxxxx;
> faraz.ata@xxxxxxxxxxx; muhammed.ali@xxxxxxxxxxx;
> selvarasu.g@xxxxxxxxxxx
> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
> 
> On 04/09/2025 19:21, Pritam Manohar Sutar wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >> Sent: 04 September 2025 03:12 PM
> >> To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>
> >> Cc: vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; robh@xxxxxxxxxx;
> >> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx;
> >> andre.draszik@xxxxxxxxxx; peter.griffin@xxxxxxxxxx;
> >> kauschluss@xxxxxxxxxxx; ivo.ivanov.ivanov1@xxxxxxxxx;
> >> igor.belwon@xxxxxxxxxxxxxxxxxxxxxxxxxx;
> >> m.szyprowski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux-
> >> phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> >> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> >> linux-samsung- soc@xxxxxxxxxxxxxxx; rosa.pila@xxxxxxxxxxx;
> >> dev.tailor@xxxxxxxxxxx; faraz.ata@xxxxxxxxxxx;
> >> muhammed.ali@xxxxxxxxxxx; selvarasu.g@xxxxxxxxxxx
> >> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy:
> >> add
> >> ExynosAutov920 HS phy compatible
> >>
> >> On 04/09/2025 09:51, Pritam Manohar Sutar wrote:
> >>> Hi Krzysztof,
> >>>
> >>>> -----Original Message-----
> >>>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >>>> Sent: 04 September 2025 12:18 PM
> >>>> To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>
> >>>> Cc: vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; robh@xxxxxxxxxx;
> >>>> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx;
> >>>> andre.draszik@xxxxxxxxxx; peter.griffin@xxxxxxxxxx;
> >>>> kauschluss@xxxxxxxxxxx; ivo.ivanov.ivanov1@xxxxxxxxx;
> >>>> igor.belwon@xxxxxxxxxxxxxxxxxxxxxxxxxx;
> >>>> m.szyprowski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux-
> >>>> phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> >>>> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> >>>> linux-samsung- soc@xxxxxxxxxxxxxxx; rosa.pila@xxxxxxxxxxx;
> >>>> dev.tailor@xxxxxxxxxxx; faraz.ata@xxxxxxxxxxx;
> >>>> muhammed.ali@xxxxxxxxxxx; selvarasu.g@xxxxxxxxxxx
> >>>> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy:
> >>>> add
> >>>> ExynosAutov920 HS phy compatible
> >>>>
> >>>> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote:
> >>>>> Document support for the USB20 phy found on the ExynosAutov920 SoC.
> >>>>> The
> >>>>> USB20 phy is functionally identical to that on the Exynos850 SoC,
> >>>>> so no driver changes are needed to support this phy. However, add
> >>>>> a dedicated compatible string for USB20 phy found in this SoC.
> >>>>>
> >>>>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>
> >>>>
> >>>> You just dropped all tags without explaining why.
> >>>
> >>> Regretted inconvenience.
> >>>
> >>> There were significant changes in supplies' names in driver and
> >>> schemas (patch-set v8). This led to make changes in patch no 5.  And
> >>> review for these changes is needed.  Hence, removed RB tag in this patch-
> set.
> >>>
> >>> There was a ask for the same https://lore.kernel.org/linux-
> >>
> phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me%
> >>
> 20know%2C%20because%20of%20above%20changes%2C%20should%20be%20
> >>
> removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch%
> >> 201%20and%203.
> >>>
> >>
> >>
> >> Where in the changelog you explained why you dropped the tags?
> >
> > Along with supplies' names, there were similar commit messages for
> > patch no 1, 3 as patch no 5 (v7). (though, they were explaining schema
> > more than h/w). Changed commit messages of the patch no 1, 3, 5 (v7)
> > as per reference commits and would like to get them reviewed again, so
> > did not add RB for patch 1 and 3, which you had given RB (in v7).
> 
> I do not have time to review the same second time and I find such request quite
> a waste of my time. It's v8 so I am surprised to see it getting changed even after
> review.	
> 

OK, those were only commit message changes, so I am going to retain your 
RB tags for patch 1 and 3. Sorry about noise.

However, do you want me to send v9 by retaining RB tags in respective patches?

> 
> Best regards,
> Krzysztof

Thank you,

Regards,
Pritam