Re: [PATCH v3 04/10] mfd: simple-mfd-i2c: add compatible string for LX2160ARDB

From: Ioana Ciornei

Date: Thu Sep 18 2025 - 07:15:19 EST


On Wed, Sep 17, 2025 at 10:20:06AM +0100, Lee Jones wrote:
> On Wed, 17 Sep 2025, Ioana Ciornei wrote:
>
> > Extend the list of supported devices with the QIXIS FPGA found on the
> > LX2160ARDB board.
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> > ---
> > Changes in v2:
> > - none
> > Changes in v3:
> > - none
> >
> > drivers/mfd/simple-mfd-i2c.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> > index 63ac26388860..6fbe85437d8d 100644
> > --- a/drivers/mfd/simple-mfd-i2c.c
> > +++ b/drivers/mfd/simple-mfd-i2c.c
> > @@ -115,6 +115,7 @@ static const struct of_device_id simple_mfd_i2c_of_match[] = {
> > { .compatible = "maxim,max5970", .data = &maxim_max5970},
> > { .compatible = "maxim,max5978", .data = &maxim_max5970},
> > { .compatible = "maxim,max77705-battery", .data = &maxim_mon_max77705},
> > + { .compatible = "fsl,lx2160ardb-fpga" },
> > { .compatible = "fsl,lx2160aqds-fpga" },
> > { .compatible = "fsl,ls1028aqds-fpga" },
> > { .compatible = "spacemit,p1", .data = &spacemit_p1, },
>
> Please keep alphabetical.

Ok, sure.

Even without this patch, the fsl compatible strings are not in
alphabetical order. Are you ok with adding another patch that fixes the
initial issue or do you want me to just do the changes in a single
patch?

Ioana