Re: [PATCH net-next v2 3/3] net: dsa: microchip: Set SPI as bus interface during reset for KSZ8463
From: Andrew Lunn
Date: Mon Sep 15 2025 - 18:00:37 EST
On Fri, Sep 12, 2025 at 11:09:14AM +0200, Bastien Curutchet wrote:
> At reset, the KSZ8463 uses a strap-based configuration to set SPI as
> bus interface. SPI is the only bus supported by the driver. If the
> required pull-ups/pull-downs are missing (by mistake or by design to
> save power) the pins may float and the configuration can go wrong
> preventing any communication with the switch.
>
> Introduce a ksz8463_configure_straps_spi() function called during the
> device reset. It relies on the 'strap-rxd*-gpios' OF properties and the
> 'reset' pinmux configuration to enforce SPI as bus interface.
>
> Signed-off-by: Bastien Curutchet (Schneider Electric) <bastien.curutchet@xxxxxxxxxxx>
Thanks for updating the commit messages, it is now a lot clearer why
this is needed.
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew