Re: [External] : Re: [PATCH] PCI: plda: Remove the use of dev_err_probe()
From: ALOK TIWARI
Date: Mon Sep 15 2025 - 15:11:12 EST
On 9/15/2025 7:37 PM, Manivannan Sadhasivam wrote:
No, I don't have bandwidth right now.Change is fine as it is. But I think devm_pci_alloc_host_bridge() should returnDid you really intend to do that,
the actual error pointer instead of NULL and let the callers guess the errno.
Callers are using both -ENOMEM and -ENODEV, both of then will mask the actual
errno that caused the failure.
Cleanup task for someone interested 🙂
- Mani
Should that be an RFC (for cleanup task) patch ?
I am planning to send a patch for this cleanup.
It will touch all files under drivers/pci/controller/,
and I hope it will be useful.
Thanks,
Alok