Re: [PATCH v2 4/7] sched_ext: Use bitfields for boolean warning flags
From: Andrea Righi
Date: Tue Sep 23 2025 - 14:46:01 EST
On Tue, Sep 23, 2025 at 06:58:06AM -1000, Tejun Heo wrote:
> Convert warned_zero_slice and warned_deprecated_rq in scx_sched struct to
> single-bit bitfields. While this doesn't reduce struct size immediately,
> it prepares for future bitfield additions.
>
> v2: Update patch description.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
Acked-by: Andrea Righi <arighi@xxxxxxxxxx>
Thanks,
-Andrea
> ---
> kernel/sched/ext_internal.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/kernel/sched/ext_internal.h
> +++ b/kernel/sched/ext_internal.h
> @@ -871,8 +871,8 @@ struct scx_sched {
> struct scx_dispatch_q **global_dsqs;
> struct scx_sched_pcpu __percpu *pcpu;
>
> - bool warned_zero_slice;
> - bool warned_deprecated_rq;
> + bool warned_zero_slice:1;
> + bool warned_deprecated_rq:1;
>
> atomic_t exit_kind;
> struct scx_exit_info *exit_info;