[PATCH 3/6] staging: axis-fifo: remove unneeded irq field from struct axis_fifo

From: Ovidiu Panait

Date: Fri Sep 19 2025 - 15:56:12 EST


The irq number returned by platform_get_irq() is stored in struct axis_fifo
during probe but it is never used afterwards. Drop the redundant irq field
and use a local variable instead.

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@xxxxxxxxx>
---
drivers/staging/axis-fifo/axis-fifo.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 33a8440858d9..c500cb0555b7 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -118,7 +118,6 @@ MODULE_PARM_DESC(write_timeout, "ms to wait before blocking write() timing out;

struct axis_fifo {
int id;
- int irq; /* interrupt */
void __iomem *base_addr; /* kernel space memory */

unsigned int rx_fifo_depth; /* max words in the receive fifo */
@@ -587,6 +586,7 @@ static int axis_fifo_probe(struct platform_device *pdev)
struct axis_fifo *fifo = NULL;
char *device_name;
int rc = 0; /* error return value */
+ int irq;

/* ----------------------------
* init wrapper device
@@ -640,17 +640,16 @@ static int axis_fifo_probe(struct platform_device *pdev)
*/

/* get IRQ resource */
- rc = platform_get_irq(pdev, 0);
- if (rc < 0)
- return rc;
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;

/* request IRQ */
- fifo->irq = rc;
- rc = devm_request_irq(fifo->dt_device, fifo->irq, &axis_fifo_irq, 0,
+ rc = devm_request_irq(fifo->dt_device, irq, &axis_fifo_irq, 0,
DRIVER_NAME, fifo);
if (rc) {
dev_err(fifo->dt_device, "couldn't allocate interrupt %i\n",
- fifo->irq);
+ irq);
return rc;
}

--
2.50.0