Re: [PATCH net-next 1/6] mptcp: pm: netlink: only add server-side attr when true

From: Jakub Kicinski

Date: Mon Sep 22 2025 - 14:52:40 EST


On Fri, 19 Sep 2025 14:08:58 +0200 Matthieu Baerts (NGI0) wrote:
> This attribute is a boolean. No need to add it to set it to 'false'.
>
> Indeed, the default value when this attribute is not set is naturally
> 'false'. A few bytes can then be saved by not adding this attribute if
> the connection is not on the server side.
>
> This prepares the future deprecation of its attribute, in favour of a
> new flag.

Removing attrs from netlink messages is a bit of a gray zone.
If anyone complains we'll have to revert..