Re: [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's

From: Abhishek Tamboli

Date: Wed Sep 24 2025 - 00:10:17 EST


On Wed, Sep 24, 2025 at 03:31:33AM +0000, Xu, Even wrote:
>
>
> > -----Original Message-----
> > From: Abhishek Tamboli <abhishektamboli9@xxxxxxxxx>
> > Sent: Tuesday, September 23, 2025 12:03 PM
> > To: Xu, Even <even.xu@xxxxxxxxx>; Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>;
> > jikos@xxxxxxxxxx; bentiss@xxxxxxxxxx
> > Cc: mpearson-lenovo@xxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; linux-
> > input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [PATCH] HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's
> >
> > Add the missing PCI ID for the quickspi device used on the Lenovo Yoga Pro 9i
> > 16IAH10.
> >
> > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=220567
> >
> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@xxxxxxxxx>
> > ---
> > drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 6 ++++++
> > drivers/hid/intel-thc-hid/intel-quickspi/quickspi-dev.h | 2 ++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > index 84314989dc53..49c8458f0118 100644
> > --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> > @@ -33,6 +33,10 @@ struct quickspi_driver_data ptl = {
> > .max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL, };
> >
> > +struct quickspi_driver_data arl = {
> > + .max_packet_size_value = MAX_PACKET_SIZE_VALUE_LNL, };
> > +
>
> As I know the THC IP in ARL is the same with in MTL, can you change this max_packet_size_value to align with MAX_PACKET_SIZE_VALUE_MTL?
Sure, I will do it.
Thanks, for the review.