Re: [PATCH v2 1/2] dt-bindings: PCI: mediatek-gen3: Add support for Airoha AN7583

[AngeloGioacchino Del Regno]

Il 24/09/25 10:36, AngeloGioacchino Del Regno ha scritto:
> Il 23/09/25 21:06, Christian Marangi ha scritto:
> > Introduce Airoha AN7583 SoC compatible in mediatek-gen3 PCIe controller
> > binding.
> >
> > This differ from the Airoha EN7581 SoC by the fact that only one Gen3
> > PCIe controller is present on the SoC.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> > ---
> > Changes v2:
> > - Fix alphabetical order
> >
> >   .../bindings/pci/mediatek-pcie-gen3.yaml      | 21 +++++++++++++++++++
> >   1 file changed, 21 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/ 
> > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > index 0278845701ce..1ca9594a9739 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -58,6 +58,7 @@ properties:
> >             - const: mediatek,mt8196-pcie
> >         - const: mediatek,mt8192-pcie
> >         - const: mediatek,mt8196-pcie
> > +      - const: airoha,an7583-pcie-gen3
>
> In the previous review, I also asked you to change the compatible string to be
> consistent with the others.
>
> airoha,an7583-pcie

I have just seen the other series where you add AN7583 to the GEN2 PCIe controller
driver; this means that this SoC has two controllers, one GEN2 and one GEN3.

The compatible string inconsistency is therefore acceptable.

Please, though - add this information in the commit message, saying that the new
string is inconsistent with the others and explain the reason.

After which,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>