Re: [PATCH v4 5/5] clk: scmi: Support Spread Spectrum for NXP i.MX95

[Sebin Francis]

Hi Peng,

On 23/09/25 17:27, Peng Fan wrote:
> Hi Sebin,
>
> > Subject: Re: [PATCH v4 5/5] clk: scmi: Support Spread Spectrum for
> > NXP i.MX95
> >
> > > --- a/include/linux/scmi_protocol.h
> > > +++ b/include/linux/scmi_protocol.h
> > > @@ -80,9 +80,14 @@ enum scmi_clock_oem_config {
> > >        SCMI_CLOCK_CFG_DUTY_CYCLE = 0x1,
> > >        SCMI_CLOCK_CFG_PHASE,
> > >        SCMI_CLOCK_CFG_OEM_START = 0x80,
> > > +     SCMI_CLOCK_CFG_IMX_SSC = 0x80,
> >
> > TI is also planning to implement the same in our upcoming platform. so
> > can we use a generic ID instead of vender specfic message ID?
>
> I tried to push to new generic ID [1] in half a year ago, but in the end ARM
> decided not to add generic ID for spread spectrum support.
>
> To i.MX, it is too late to use a generic ID and waiting spec, i.MX firmware
> has been public for quite some time and passed several external releases.
> So I need to use what our firmware adds and spec allows: vendor
> extension.

Thanks for the quick response,
Since this implementation is specific to i.MX, can you move this to a 
vendor specific file, so that it will not break i.MX's firmware and TI 
can implement SSC in TI specific file.

> [1] https://lore.kernel.org/arm-scmi/Z8iKErarE0lHWxEy@pluto/
>
> Regards,
> Peng.

Thanks
Sebin