Re: [PATCH v2 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8189 scp

[AngeloGioacchino Del Regno]

Il 24/09/25 10:44, Huayu Zong ha scritto:
> Add the compatible for mt8189 SCP to the binding.
>
> Signed-off-by: Huayu Zong <huayu.zong@xxxxxxxxxxxx>

Please fix the commit description.

Example:

Add a new compatible for MT8189's SCP: even though this is partially
compatible with the SCP found in MT8192, the register layout has some
slight differences.

...after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogiaocchino.delregno@xxxxxxxxxxxxx>

> ---
>   Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index 179c98b33b4d..407be544b404 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -20,6 +20,7 @@ properties:
>         - mediatek,mt8186-scp
>         - mediatek,mt8188-scp
>         - mediatek,mt8188-scp-dual
> +      - mediatek,mt8189-scp
>         - mediatek,mt8192-scp
>         - mediatek,mt8195-scp
>         - mediatek,mt8195-scp-dual
> @@ -168,6 +169,7 @@ allOf:
>               - mediatek,mt8183-scp
>               - mediatek,mt8186-scp
>               - mediatek,mt8188-scp
> +            - mediatek,mt8189-scp
>       then:
>         properties:
>           reg: