Re: [PATCH 2/4] hwmon: (dell-smm) Move clamping of fan speed out of i8k_set_fan()
From: Guenter Roeck
Date: Wed Sep 24 2025 - 10:47:41 EST
On Wed, Sep 17, 2025 at 08:10:34PM +0200, Armin Wolf wrote:
> Currently i8k_set_fan() clamps the fan speed before performing the
> SMM call to ensure that the speed is not negative and not greater than
> i8k_fan_max. This however is mostly unnecessary as the hwmon and
> thermal interfaces alread ensure this. Only the legacy ioctl interface
> does not ensure that the fan speed passed to i8k_set_fan() does meet
> the above criteria.
>
> Move the clamping out of i8k_set_fan() and into the legacy ioctl
> handler to prepare for future changes.
>
> Signed-off-by: Armin Wolf <W_Armin@xxxxxx>
Applied.
Guenter